Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of RFID reader RC522 fails due to deleted repo #2066

Closed
jo-me opened this issue Sep 18, 2023 · 6 comments · Fixed by #2075
Closed

Installation of RFID reader RC522 fails due to deleted repo #2066

jo-me opened this issue Sep 18, 2023 · 6 comments · Fixed by #2075
Labels
bug ext dependency future3 Relates to future3 development

Comments

@jo-me
Copy link

jo-me commented Sep 18, 2023

Describe your problem

The repository used to install the RC522 library apparently disappeared: https://github.com/ChisSoc/pi-rc522.git

It is configured in
https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/future3/main/src/jukebox/components/rfid/hardware/rc522_spi/requirements.txt

The commented out one (kevinvalk) seems to work.

What's your hardware set up?

RPi2. RC522

@jo-me jo-me added bug future3 Relates to future3 development needs triage labels Sep 18, 2023
@s-martin
Copy link
Collaborator

Hey @pabera, @MiczFlor,

looks like ChisSoc deleted his GitHub account.

Do you remember why we forked the original repo?

@pabera
Copy link
Collaborator

pabera commented Sep 18, 2023

I don't remember it. This was @chrissoc's contribution only. In the config mentioned above they explain the reasoning behind it. We should be good with what @jo-me suggested. Would required a PR.

@s-martin
Copy link
Collaborator

@AlvinSchiller i think we need to fix this in 2.x as well: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/develop/components/rfid-reader/RC522/requirements.txt

@AlvinSchiller
Copy link
Collaborator

@AlvinSchiller i think we need to fix this in 2.x as well: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/develop/components/rfid-reader/RC522/requirements.txt

I was wondering why this is not a problem in 2.x but then forgot to check 😅

@s-martin
Copy link
Collaborator

I made a PR #2078 :)

@s-martin
Copy link
Collaborator

s-martin commented Nov 9, 2023

#2075 and #2078 are merged, so this should be fixed on the develop branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ext dependency future3 Relates to future3 development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants