Bugfix: re-enable Mifare Ultralight C support #2214
Conversation
Make use of read_id function from pirc552 package to reenable Mifare Ultralight C support. ATTENTION: Previously a non-standard representation of NFC card uid was returned by the Mfrc522Reader class. With this change a standard representation of the NFCs uid is return which breaks all currently stored links between cards and actions.
Pull Request Test Coverage Report for Build 7705488041
💛 - Coveralls |
|
If I understand you correctly, this will be a breaking change on existing installations. future3 asks, if the „legacy“ mode shall be used during installation. We need to check, how this could be implemented with little impact. |
s-martin
added
bug
investigation needed
legacy_v2
Add a legacy mode similar to 'future3' implementation. Use the legacy mode to allow correction of card uid read with Mfrc522 while keeping the class backward compatibil, cf. 'future3' handling.
|
Like in future3, I have now implemented a „legacy“ mode that can be deactivated via a file in the @s-martin Thanks for pointing out this issue. |
|
Maybe also add this to the RC522 setup, so the user can choose at this point which mode to use? |
Modified general legacy mode to a specific option of the rc522 reader that allows to change between the read of the usual UID and the read of the previous custom implementation of card ID.
Extend rc522 setup script to question user for the usage of UID mode rather than the old custom card ID.
See my attempt in cd883df. |
|
Looks good to me now :) |
Make use of read_id function from pirc522 package to re-enable Mifare Ultralight C support.
Since the change of the pirc522 repo, cf. #2066, #2075, #2078, I have realized issues with Mifare Ultralight C stickers in my setup (RPi Zero 2). Moving from the previous "more manual" check of uid to the read_id function of the pirc522 package fixes this issue.
ATTENTION:
Previously, a non-standard representation of NFC card uid was returned by the Mfrc522Reader class. With this change a standard representation of the NFCs uid is return which breaks all currently stored links between cards and actions. Writing a converter appears not possible due to the way "uids" were put together previously. Like in future3 the old variant was labelled "legacy".