Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for serializable #1953

Merged
merged 2 commits into from
Mar 2, 2023
Merged

add patch for serializable #1953

merged 2 commits into from
Mar 2, 2023

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Jan 2, 2023

This should fix the serializable issue in the test: https://github.com/mpyw/phpunit-patch-serializable-comparison

see also: sebastianbergmann/phpunit#4371

@s-martin s-martin added this to the 2.x(.x) next milestone Jan 2, 2023
@s-martin s-martin marked this pull request as draft January 2, 2023 23:44
@s-martin
Copy link
Collaborator Author

s-martin commented Jan 4, 2023

If I run the tests of this branch in a Github codespace, it works.
Unclear why this works not with the Github Action

@s-martin s-martin marked this pull request as ready for review March 2, 2023 20:45
@s-martin s-martin merged commit cc6cc64 into develop Mar 2, 2023
@s-martin s-martin deleted the fix-tests branch March 2, 2023 20:47
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Dec 21, 2023
* add patch for serializable

* Update php.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant