Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShutdownButton LED does not stay on after hold time has expired and shutdown is ongoing #1984

Conversation

topas-rec
Copy link
Contributor

* Handler gets called when pushing AND releasing the button
* The handler should be called only when the button is pressed, as configured here: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/develop/components/gpio_control/GPIODevices/simple_button.py#L86
@s-martin s-martin added the bug label Mar 11, 2023
@s-martin s-martin added this to the 2.5 milestone Mar 11, 2023
@s-martin
Copy link
Collaborator

Thanks for fixing this bug

@s-martin s-martin merged commit b943248 into MiczFlor:develop Mar 12, 2023
@topas-rec topas-rec deleted the fix_shutdownButton_LED_does_not_stay_on_after_hold_time_has_expired_and_shutdown_is_ongoing branch March 18, 2023 07:27
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Dec 21, 2023
* Handler gets called when pushing AND releasing the button
* The handler should be called only when the button is pressed, as configured here: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/develop/components/gpio_control/GPIODevices/simple_button.py#L86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 | ShutdownButton LED does not stay on after hold time has expired and shutdown is ongoing
2 participants