Make changes for Raspberry Pi OS Bookworm #2084

s-martin · 2023-10-22T20:00:57Z

Make changes so Phoniebox 2.x runs on Bookworm (this PR replaces #2080)

Changes:

Use bookworm in Github Actions
Use "--break-system-packages" as Bookworm implemented PEP668, but 2.x is legacy anyway
Explicitly install netcat-traditional package

TODOs:

MPD does not start, see https://github.com/MiczFlor/RPi-Jukebox-RFID/actions/runs/6771845838/job/18403246976?pr=2084#step:6:1898 Configuring MPD... MPD error: Cannot assign requested address
installing rfid reader does not work yet, see https://github.com/MiczFlor/RPi-Jukebox-RFID/actions/runs/6771845838/job/18403247429?pr=2084 Line 1914;
there is also a check missing for test 2 --> will be fixed in Further Optimizations #2092
Spotify packages cant be installed anymore (probably not necessary), see https://github.com/MiczFlor/RPi-Jukebox-RFID/actions/runs/6771845838/job/18403247790?pr=2084
should be fixed by Implemented fixes for RPi recognition and new spotify GST plugin compile #2064
Coveralls seems also not to like the parallel builds suddenly in the Python checks; fix see here: https://docs.coveralls.io/parallel-builds

* use venv as Bookworm implemented PEP668 * explicitly install netcat-traditional package

s-martin · 2023-10-22T21:30:03Z

The enforcement of PEP668 seems not so easy to solve, right now I'm not sure whats the best way for us.

Some references:

s-martin · 2023-11-03T10:20:26Z

Some more opinions on PEP 668: raspberrypi/bookworm-feedback#100

pabera · 2023-11-03T11:57:39Z

Some more opinions on PEP 668: raspberrypi/bookworm-feedback#100

Do you have trouble using Python in venv?

s-martin · 2023-11-03T12:25:12Z

It's more my lack of knowledge of venvs, so far I avoided them pretty successful ;)

@pabera, maybe you can have a look at the changes I tried in this PR - I'm pretty sure that it's solvable, but I don't have enough experience with venvs to choose the best solution for us.

AlvinSchiller · 2023-11-03T12:37:15Z

I would try a bit too if i have time, but i have also not much experience with python and venvs.
But from the links you provided, i think we have two options:

use break-system-packages and leave everything as is (more of a legacy solution, but maybe the easiest for 2.x)
correctly adapt to "PEP 668" and create and use a venv in the RPi-Jukebox-RFID root folder. Then every python, pip or shebang path has to point to this venv folder (could be troublesome as this should be relativ path? ).

pabera · 2023-11-03T12:59:21Z

It would be a very idealistic approach to solve this for V2, I agree with @AlvinSchiller. But because we rely on Python a lot more in V3, this could be a heavy lift.

s-martin · 2023-11-03T13:07:54Z

I also think for legacy 2.x break system packages should be fine.

…worm_adaptation # Conflicts: # scripts/installscripts/buster-install-default-with-autohotspot.sh

coveralls · 2023-11-04T15:49:54Z

Pull Request Test Coverage Report for Build 6804281312

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.82%

Totals
Change from base Build 6755756729:	0.0%
Covered Lines:	633
Relevant Lines:	824

💛 - Coveralls

AlvinSchiller · 2023-11-06T18:30:23Z

Hey @s-martin,
instead of changing every python call, it is possible to set an global config entry, so theres no need to remember adding it.
Plus its backwards compatible:
sudo python3 -m pip config set global.break-system-packages true

see: https://github.com/AlvinSchiller/RPi-Jukebox-RFID/tree/test/bookworm

AlvinSchiller · 2023-11-06T18:54:19Z

rfidreader * Line 1914; there is also a check missing for test 2

You probably mean the check for package 532 and 522? I fixed them in #2092

s-martin · 2023-11-06T21:12:30Z

Spotify packages seem not to be available for Bookworm:

pi@phoniebox:/etc$ sudo apt install libspotify-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package libspotify-dev

pi@phoniebox:/etc$ apt search mopidy
Sorting... Done
Full Text Search... Done
gir1.2-playerctl-2.0/stable 2.4.1-2 amd64
  utility to control media players via MPRIS (gir bindings)

libplayerctl-dev/stable 2.4.1-2 amd64
  utility to control media players via MPRIS (development files)

libplayerctl-doc/stable 2.4.1-2 all
  utility to control media players via MPRIS (documentation)

libplayerctl2/stable 2.4.1-2 amd64
  utility to control media players via MPRIS (library)

mopidy/stable 3.4.2-1 all
  extensible music server

mopidy-alsamixer/stable 2.0.1-1 all
  Mopidy extension for volume control via ALSA

mopidy-beets/stable 4.0.1-1 all
  Mopidy extension for playing music from Beets' web plugin

mopidy-dleyna/stable 2.0.2-1 all
  Mopidy extension for playing music from Digital Media Servers

mopidy-doc/stable 3.4.2-1 all
  extensible music server - documentation

mopidy-internetarchive/stable 3.0.1-1 all
  Mopidy extension for playing music from the Internet Archive

mopidy-local/stable 3.2.1-1 all
  Mopidy extension for playing music from your local music archive

mopidy-mpd/stable 3.3.0-1 all
  Mopidy extension for controlling Mopidy from MPD clients

mopidy-mpris/stable 3.0.3-1 all
  Mopidy extension for controlling playback through MPRIS

mopidy-podcast/stable 3.0.1-1 all
  Mopidy extension for searching and browsing podcasts

mopidy-podcast-itunes/stable 3.0.1-1 all
  Mopidy extension for searching and browsing iTunes podcasts

mopidy-scrobbler/stable,stable 2.0.1-1 all
  Mopidy extension for scrobbling music to Last.fm

mopidy-somafm/stable 2.0.2-1 all
  Mopidy extension for playing music from SomaFM

mopidy-soundcloud/stable 3.0.2-1 all
  Mopidy extension for playing music from SoundCloud

mopidy-tunein/stable 1.1.0-1 all
  Mopidy extension for playing music from TuneIn

playerctl/stable 2.4.1-2 amd64
  utility to control media players via MPRIS

snapserver/stable 0.26.0+dfsg1-1+b2 amd64
  Snapcast server

AlvinSchiller · 2023-11-07T14:35:22Z

The "MPDConfig" block need to be moved ahead of "SPOTInstall" so the mpd service enablement is correct in the end.

s-martin · 2023-11-07T14:37:00Z

I fixed it by explicitly stopping and disabling mpd, when Spotify is used.

AlvinSchiller · 2023-11-07T15:01:43Z

I fixed it by explicitly stopping and disabling mpd, when Spotify is used.

Yep but Spotifyinstall and mpdconfig are not mutually exclusive. So the Spotify block will disable mpd service and the mpd block after will enable it again, which is not a correct state.

DivineDominion · 2023-11-08T07:34:53Z

Sorry if I'm bringing this up here: it sounds that (usage of) libspotify is dead anyway at the moment. So maybe TODO item number 3 of @s-martin's original PR comment should not be a blocker if the rest of the PR is going well?

* fixed markdown warnings * fix flake warnings * * use bookworm * use venv as Bookworm implemented PEP668 * explicitly install netcat-traditional package * dont sudo activate * allow breaking system packages * fix break-system-packages, as this switch doesnt exist pre bookworm * improve command for break system packages * set break system packages globally * fix permissions for mpd.conf * revert last commit * explictily start mpd * explicitly stop mod when using Spotify * use parallel for coveralls

s-martin added 4 commits October 18, 2023 22:24

fixed markdown warnings

f139314

fix flake warnings

02b8c68

Merge remote-tracking branch 'remotes/upstream/develop' into develop

0924bfe

* use bookworm

6fa77cc

* use venv as Bookworm implemented PEP668 * explicitly install netcat-traditional package

s-martin added the enhancement label Oct 22, 2023

s-martin mentioned this pull request Oct 22, 2023

Run docker images on bookworm #2080

Closed

dont sudo activate

84128dd

AlvinSchiller mentioned this pull request Oct 24, 2023

Update Documentation #2008

Merged

4 tasks

s-martin added 3 commits November 3, 2023 14:44

allow breaking system packages

ef235d7

fix break-system-packages, as this switch doesnt exist pre bookworm

e51672a

Merge remote-tracking branch 'remotes/upstream/develop' into new_book…

7aebf86

…worm_adaptation # Conflicts: # scripts/installscripts/buster-install-default-with-autohotspot.sh

improve command for break system packages

0b40404

s-martin added 2 commits November 6, 2023 21:20

set break system packages globally

9569d5d

fix permissions for mpd.conf

7cd2fdb

s-martin and others added 3 commits November 6, 2023 22:22

revert last commit

c6ea49c

explictily start mpd

435ca8b

explicitly stop mod when using Spotify

36bd6ea

use parallel for coveralls

0dacdc2

s-martin added this to the 2.5 milestone Nov 8, 2023

s-martin merged commit 093cc61 into MiczFlor:develop Nov 8, 2023
28 of 31 checks passed

s-martin mentioned this pull request Nov 8, 2023

Further Optimizations #2092

Merged

7 tasks

s-martin deleted the new_bookworm_adaptation branch January 4, 2024 22:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make changes for Raspberry Pi OS Bookworm #2084

Make changes for Raspberry Pi OS Bookworm #2084

s-martin commented Oct 22, 2023 •

edited

Loading

s-martin commented Oct 22, 2023

s-martin commented Nov 3, 2023

pabera commented Nov 3, 2023

s-martin commented Nov 3, 2023 •

edited

Loading

AlvinSchiller commented Nov 3, 2023

pabera commented Nov 3, 2023

s-martin commented Nov 3, 2023

coveralls commented Nov 4, 2023 •

edited

Loading

AlvinSchiller commented Nov 6, 2023 •

edited

Loading

AlvinSchiller commented Nov 6, 2023

s-martin commented Nov 6, 2023

AlvinSchiller commented Nov 7, 2023

s-martin commented Nov 7, 2023

AlvinSchiller commented Nov 7, 2023

DivineDominion commented Nov 8, 2023

Make changes for Raspberry Pi OS Bookworm #2084

Make changes for Raspberry Pi OS Bookworm #2084

Conversation

s-martin commented Oct 22, 2023 • edited Loading

s-martin commented Oct 22, 2023

s-martin commented Nov 3, 2023

pabera commented Nov 3, 2023

s-martin commented Nov 3, 2023 • edited Loading

AlvinSchiller commented Nov 3, 2023

pabera commented Nov 3, 2023

s-martin commented Nov 3, 2023

coveralls commented Nov 4, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6804281312

Warning: This coverage report may be inaccurate.

💛 - Coveralls

AlvinSchiller commented Nov 6, 2023 • edited Loading

AlvinSchiller commented Nov 6, 2023

s-martin commented Nov 6, 2023

AlvinSchiller commented Nov 7, 2023

s-martin commented Nov 7, 2023

AlvinSchiller commented Nov 7, 2023

DivineDominion commented Nov 8, 2023

s-martin commented Oct 22, 2023 •

edited

Loading

s-martin commented Nov 3, 2023 •

edited

Loading

coveralls commented Nov 4, 2023 •

edited

Loading

AlvinSchiller commented Nov 6, 2023 •

edited

Loading