Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the run_rpc_tool script #2166

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Improve the run_rpc_tool script #2166

merged 5 commits into from
Dec 19, 2023

Conversation

s-martin
Copy link
Collaborator

Improve the script to use commands directly, e.g. run_rpc_tool.py -c host.shutdown. The CLI Client (C implementation) could be removed later.

@s-martin s-martin added enhancement future3 Relates to future3 development labels Dec 15, 2023
@s-martin s-martin self-assigned this Dec 15, 2023
@coveralls
Copy link

coveralls commented Dec 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7267757358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.384%
Totals Coverage Status
Change from base Build 7266398559: 0.0%
Covered Lines: 418
Relevant Lines: 1089
💛 - Coveralls

@s-martin s-martin merged commit 0a5d429 into future3/develop Dec 19, 2023
22 checks passed
@s-martin s-martin deleted the future3/improve-run-rpc-tool branch December 19, 2023 22:19
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Jan 9, 2024
@s-martin @AlvinSchiller
Improve the run_rpc_tool script (MiczFlor#2166)
7a62381 
* add possibility to execute commands directly

* add documentation

* ignore node modules in flakek8

* fix comments
@pabera pabera added this to the v3.5 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvinSchiller AlvinSchiller AlvinSchiller approved these changes

@pabera pabera Awaiting requested review from pabera

Assignees

@s-martin s-martin

Labels
enhancement future3 Relates to future3 development
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@s-martin @coveralls @AlvinSchiller @pabera