Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate codeql analysis #2182

Merged
merged 8 commits into from
Dec 28, 2023
Merged

Activate codeql analysis #2182

merged 8 commits into from
Dec 28, 2023

Conversation

s-martin
Copy link
Collaborator

No description provided.

@s-martin s-martin added the future3 Relates to future3 development label Dec 28, 2023
@s-martin
Copy link
Collaborator Author

Maybe need to check this as well: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#analyzing-python-dependencies

AlvinSchiller
AlvinSchiller approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@AlvinSchiller AlvinSchiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recomment to rename the file and name with "v3" suffix.
Had the same with the installation ci and it breaks the badges, if both branches are bundled together in "one action" in the menu.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@s-martin s-martin merged commit 3a904b5 into future3/develop Dec 28, 2023
3 checks passed
@s-martin s-martin deleted the future3/codeql branch December 28, 2023 12:35
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Jan 9, 2024
@s-martin @AlvinSchiller
Activate codeql analysis (MiczFlor#2182)
df33426 
* Activate codeql analysis

* Update codeql version

* Update checkout version

* Rename workflow file

* Update name of workflow

* Setup Python deps manually

* Install packages

* Fix packages
@pabera pabera added this to the v3.5 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvinSchiller AlvinSchiller AlvinSchiller approved these changes

Assignees
No one assigned
Labels
future3 Relates to future3 development
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@s-martin @AlvinSchiller @pabera