Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkManager Support #2261

Merged
merged 35 commits into from
Mar 19, 2024

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Feb 15, 2024

  • Update autohotspot based on dhcpcd
  • Add autohotspot based on NetworkManager
  • Update "Static IP" setup for NetworkManager
    • add ci tests
  • Update new Wifi via WebUi
    • Fixes "Initial Wifi is not shown"
    • New behavior: Active connection is readonly
  • Update docs

@AlvinSchiller AlvinSchiller added installation legacy_v2 Issues, discussions and PRs related to Version 2.x labels Feb 15, 2024
@AlvinSchiller AlvinSchiller added this to the v2.6 milestone Feb 15, 2024
@AlvinSchiller AlvinSchiller self-assigned this Feb 15, 2024
@coveralls
Copy link

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 8335308844

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 78.435%

Totals Coverage Status
Change from base Build 8016382420: 1.6%
Covered Lines: 451
Relevant Lines: 575

💛 - Coveralls

Copy link
Collaborator

@s-martin s-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's similar to the PR for future3, correct?

@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Feb 15, 2024

It's similar to the PR for future3, correct?

Yep, the autohotspot funtionality is the same. The integration in the setup is different.

@AlvinSchiller AlvinSchiller linked an issue Feb 15, 2024 that may be closed by this pull request
scripts/installscripts/install-jukebox.sh Outdated Show resolved Hide resolved
@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Mar 13, 2024

@s-martin
I would suggest to change the default option for wifi/staticip setup to "no".

With the rpi-imager the wifi can already be preset, and i think a staticip is only relevant in edge cases (ip can be fixed in most routers and is also the recommended way for RPi OS).
If the user needs this feature it can actively be chosen.
I think this reduces confusion and misconfiguration.

What do you think?

@s-martin
Copy link
Collaborator

I agree. I think static is an edge case.

@AlvinSchiller AlvinSchiller marked this pull request as ready for review March 14, 2024 23:03
@AlvinSchiller
Copy link
Collaborator Author

Ready to merge.
Also tested with the newest Bookworm Release and Kernel 6.6

@s-martin
Copy link
Collaborator

Do it :)

@AlvinSchiller AlvinSchiller merged commit 33f240b into MiczFlor:develop Mar 19, 2024
33 of 34 checks passed
@AlvinSchiller AlvinSchiller deleted the feature/networkmanager branch March 20, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 | Network Settings in Bookworm
3 participants