Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for pyzmq installation #2272

Merged

Conversation

AlvinSchiller
Copy link
Collaborator

fixes #2271
pyzmq installation fails due to the latest prerelease.

Fix: removed the --pre argument to use the latest release, which is known to work.

@AlvinSchiller AlvinSchiller linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@pabera pabera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix it in Docker as well?

RUN pip install -v --no-binary pyzmq --pre pyzmq

@s-martin
Copy link
Collaborator

Should we fix it in Docker as well?

RUN pip install -v --no-binary pyzmq --pre pyzmq

Yes

@AlvinSchiller
Copy link
Collaborator Author

Should we fix it in Docker as well?

RUN pip install -v --no-binary pyzmq --pre pyzmq

Done with dont use prereleases (docker)

@s-martin
Copy link
Collaborator

Reference: this should also fix #2268

@AlvinSchiller
Copy link
Collaborator Author

pyzmq version 26.0.0a3 fixes the build error, so installations with the pre-release are possible again.

Will still merge this to make the installation more stable.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7965715746

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.2%

Totals Coverage Status
Change from base Build 7865264660: 0.0%
Covered Lines: 416
Relevant Lines: 1089

💛 - Coveralls

@AlvinSchiller AlvinSchiller merged commit 5138bb5 into MiczFlor:future3/main Feb 19, 2024
14 of 18 checks passed
@AlvinSchiller AlvinSchiller deleted the future3/hotfix/pyzmq branch February 19, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build pyzmq
5 participants