Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to config.txt for bookworm support #2298

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

AlvinSchiller
Copy link
Collaborator

Up to Bullseye, the config.txt file is located at /boot/. Since Bookworm, the location changed to /boot/firmware/, see here.

  • Added logic to retrieve correct path from future3 as helperscript
  • fixed gpio service name in pirateHat setup

closes #2262

@AlvinSchiller AlvinSchiller added installation legacy_v2 Issues, discussions and PRs related to Version 2.x labels Mar 19, 2024
@AlvinSchiller AlvinSchiller added this to the v2.6 milestone Mar 19, 2024
@AlvinSchiller AlvinSchiller self-assigned this Mar 19, 2024
@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8343476709

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.435%

Totals Coverage Status
Change from base Build 8340470383: 0.0%
Covered Lines: 451
Relevant Lines: 575

💛 - Coveralls

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view we could remove the manual description of the steps, which are done by the script.
Users should use the script and we would avoid duplication

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked the Readme

@AlvinSchiller AlvinSchiller merged commit 7e7e0a6 into MiczFlor:develop Mar 19, 2024
33 of 34 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/boot_config branch March 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 | PirateAudioHat Setup for Bookworm
3 participants