Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HasEsp32 and KeyRev #116

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

pscheidler
Copy link
Member

@pscheidler pscheidler self-assigned this Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #116 (e1905e1) into develop (bc383b3) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    74.17%   74.23%   +0.06%     
===========================================
  Files           10       10              
  Lines         3647     3757     +110     
===========================================
+ Hits          2705     2789      +84     
- Misses         942      968      +26     
Impacted Files Coverage Δ
idelib/importer.py 62.09% <0.00%> (+5.39%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@StokesMIDE
Copy link
Member

We were also talking about a HwCustomRev element... Does the existing HwCustomStr element address this, and we just forgot about it? Or does it have a slightly different role?

@pscheidler pscheidler merged commit b639b3b into develop Mar 25, 2022
@pscheidler pscheidler deleted the feature/EF-171_add_recprops_elements branch March 25, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants