Feature/es 563 get range indices fix #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem lies in timestamp generation: times at ChannelDataBlock indices don't match block's start/end times!
Codecov Report
@@ Coverage Diff @@
## develop #138 +/- ##
===========================================
- Coverage 74.48% 74.28% -0.21%
===========================================
Files 10 10
Lines 3680 3690 +10
===========================================
Hits 2741 2741
- Misses 939 949 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This needs unit tests of the range-getting functions before it can be approved. Not having them got us into this mess in the first place. |
Added minor fix for a couple `EventArray` methods with no data Removed some apparently unused CSV files from tests (may need to restore later)
pscheidler
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with getting ranges with start and/or end times falling between ChannelDataBlocks. Also made getting an index for a time more reliable.