compile with strict flags

-Wall -Wextra -Werror -pedantic
Also passing in -Wno-unused-parameter because there are a lot of unused parameters, but (void) variable might not be desirable

xddfunc_numactl is now surrounded by HAVE_CPU_SET_T instead of HAVE_ENABLE_NUMA

.github/workflows/ci.yml

@@ -7,6 +7,8 @@ jobs:
     name: build
 
     runs-on: ubuntu-latest
+    env:
+      CFLAGS: -Wall -Wextra -Werror -pedantic -Wno-unused-parameter
     strategy:
       matrix:
         img: ["ubuntu:20.04", "ubuntu:22.04", "centos:8" ]

src/client/info_display.c

@@ -141,8 +141,6 @@ xdd_target_info(FILE *out, target_data_t *tdp) {
 	//ptds_t 				*masterp, *slavep;
 	//lockstep_t			*master_lsp, *slave_lsp;
 	xint_data_pattern_t	*dpp;
-	unsigned int j;
-
 	fprintf(out,"\tTarget number, %d\n",tdp->td_target_number);
 	fprintf(out,"\t\tFully qualified target pathname, '%s'\n",tdp->td_target_full_pathname);
 	fprintf(out,"\t\tTarget directory, %s\n",(strlen(tdp->td_target_directory)==0)?"\"./\"":tdp->td_target_directory);
@@ -151,7 +149,7 @@ xdd_target_info(FILE *out, target_data_t *tdp) {
 #if HAVE_CPU_SET_T
     if (strlen(tdp->numa_node_list) > 0) {
 		fprintf(out, "\t\tWorker threads pinned in NUMA domains, ");
-		for (j = 0; j < strlen(tdp->numa_node_list); j++) {
+		for (size_t j = 0; j < strlen(tdp->numa_node_list); j++) {
 			if (j != strlen(tdp->numa_node_list) - 1)
 				fprintf(out, "%c, ", tdp->numa_node_list[j]);
 			else

src/client/parse_func.c

@@ -2318,7 +2318,7 @@ xddfunc_noproclock(xdd_plan_t *planp, int32_t argc, char *argv[], uint32_t flags
 		xgp->global_options |= GO_NOPROCLOCK;
     return(1);
 }
-#if HAVE_ENABLE_NUMA
+#if HAVE_CPU_SET_T
 /*----------------------------------------------------------------------------*/
 // Specify the NUMA domain to pin worker threads of a particular target
 // Arguments: -numactl [target #] #[,#]*
@@ -2355,7 +2355,7 @@ xddfunc_numactl(xdd_plan_t *planp, int32_t argc, char *argv[], uint32_t flags)
 		return(2);
 	}
 }
-#endif /* HAVE_ENABLE_NUMA */
+#endif /* HAVE_CPU_SET_T */
 /*----------------------------------------------------------------------------*/
 // Specify the number of requests to run
 // Arguments: -numreqs [target #] #

src/client/parse_table.c

@@ -351,7 +351,7 @@ xdd_func_t  xdd_func[] = {
             {"    Will set not lock process into memory\n",
             0,0,0,0},
 			0},
-#if HAVE_ENABLE_NUMA
+#if HAVE_CPU_SET_T
     {"numactl", "numa",
             xddfunc_numactl,
             1,

src/client/utils.c

@@ -79,6 +79,7 @@ xdd_random_int(void) {
 
 #if HAVE_RANDOM
     return random();
+#endif
 #elif HAVE_RAND
     return rand();
 #endif