Only print NUMA nodes if requested #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating the build system to CMake XDD was outputing the NUMA domain for each worker thread in the header of the output. This address that issue by printing that info in the event it is requested through the `-debug` flag. Since the `GO_DEBUG_USER1` global debug was never used, it was updated to be used for init debugging and changed to GO_DEBUG_INIT. So if the user does `-debug init` they will now see what cpus the worker threads have been pinned to. As part of the work, I also reorganized the test directory a bit. I made a separate debug test directory just to test out this functionality as it really did not make sense for it to be in the fuctional test cases. I placed all the common test CMake variables in the CMakeLists.txt and then just added individual test information in the functional and debug CMakeLists.txt files. Fixes #13 Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
bwatkinson
force-pushed
the
fix_numa_debug
branch
from
8bc6e0a
to
4fb49df
Compare
calccrypto
reviewed
Jul 27, 2023
calccrypto
reviewed
Jul 27, 2023
calccrypto
reviewed
Jul 27, 2023
SQAUSH before merging I overlooked cleaning up the CMakeLists.txt in the debug test case directory. This fixes that oversight. Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
SQUASH before merging Made updates to test_xdd_debug_init.sh to just call XDD directly without putting it in a string first. Not sure what the idea was behind the redirection of the shell scripts to the log file was. As fas as I can tell, it never resulted in anything being written out to test-dir/logs. For now, I am just getting rid of the redirection till someone can show me what it was suppose to do. Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
bwatkinson
force-pushed
the
fix_numa_debug
branch
from
9ccf593
to
f39107c
Compare
calccrypto
approved these changes
Jul 27, 2023
MigeljanImeri
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the build system to CMake XDD was outputing the NUMA domain for each worker thread in the header of the output. This address that issue by printing that info in the event it is requested through the
-debugflag.Since the
GO_DEBUG_USER1global debug was never used, it was updated to be used for init debugging and changed to GO_DEBUG_INIT. So if the user does-debug initthey will now see what cpus the worker threads have been pinned to.As part of the work, I also reorganized the test directory a bit. I made a separate debug test directory just to test out this functionality as it really did not make sense for it to be in the fuctional test cases. I placed all the common test CMake variables in the CMakeLists.txt and then just added individual test information in the functional and debug CMakeLists.txt files.
Fixes #13
Signed-off-by: Brian Atkinson batkinson@lanl.gov