Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common.sh Weirdness #27

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

calccrypto
Copy link
Collaborator

@calccrypto calccrypto commented Sep 13, 2023

tests/CMakeLists.txt was calling configure_file without a copy method, and it was copying common.sh weirdly
also fixed a few other issues that were prevented by this issue/missed in the previous shellcheck commit

updated test_xdd_reopen.sh

tests/CMakeLists.txt was calling configure_file without a copy method, and it was copying common.sh weirdly
also fixed a few other issues that were prevented by this issue/missed in the previous shellcheck commit
updated test_xdd_reopen.sh
    grep for the words, not just the strings
    ignoring syscall count mismatches for now (see MigeljanImeri#19)
@bwatkinson
Copy link
Collaborator

@calccrypto can you update this to also have a commit where we just skip the test_xdd_reopen test case and open an issue? That is something we need to figure out, but that can be done in another PR.

@bwatkinson
Copy link
Collaborator

@calccrypto can you update this to also have a commit where we just skip the test_xdd_reopen test case and open an issue? That is something we need to figure out, but that can be done in another PR.

@calccrypto I just realized you already had the reopen test_finalize passing -1 on failure. I didn't notice that before. We probably can just drop your latest commit for the CMake variable and just merge the your initial commit in. Sorry for now noticing this before now.

@calccrypto calccrypto merged commit a3510a7 into MigeljanImeri:xdd-2.0 Sep 25, 2023
8 checks passed
@calccrypto calccrypto deleted the shellcheck2 branch September 25, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants