Fixed issue with dryrun option that caused hanging #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calccrypto
reviewed
Sep 13, 2023
calccrypto
reviewed
Sep 13, 2023
calccrypto
reviewed
Sep 13, 2023
calccrypto
reviewed
Sep 13, 2023
Fixed an issue with the dryrun option that would cause xdd to hang whenever the option was enabled. The issue lied in src/client/results_manager.c, as it was stuck waiting in a barrier for the other threads to also enter the barrier, which they would never do as the other threads have already exited. Also added a test to ensure that the dryrun option functions correctly. Signed-off-by: MigeljanImeri <ImeriMigel@gmail.com>
MigeljanImeri
force-pushed
the
dryrun-option-hanging
branch
from
748d0c3
to
301d8ea
Compare
calccrypto
approved these changes
Sep 13, 2023
|
@MigeljanImeri I am not sure what is going on here, but this command still hangs: |
bwatkinson
approved these changes
Sep 25, 2023
Never mind, I was a moron and ran the wrong XDD binary. This looks good and sorry for the confusion on my end. |
MigeljanImeri
added a commit
that referenced
this pull request
Sep 28, 2023
Fixed an issue with the dryrun option that would cause xdd to hang whenever the option was enabled. The issue lied in src/client/results_manager.c, as it was stuck waiting in a barrier for the other threads to also enter the barrier, which they would never do as the other threads have already exited. Also added a test to ensure that the dryrun option functions correctly. Signed-off-by: MigeljanImeri <ImeriMigel@gmail.com> Co-authored-by: MigeljanImeri <ImeriMigel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the dryrun option that would cause xdd to hang whenever the option was enabled. The issue lied in src/client/results_manager.c, as it was stuck waiting in a barrier for the other threads to also enter the barrier, which they would never do as the other threads have already exited.
Also added a test to ensure that the dryrun option functions correctly.