Fix segfault in XDD when buffer file is smaller than reqsize with -datapattern wholefile #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadegore
changed the title
cadegore
force-pushed
the
cadegore-xdd
branch
from
0ebbeb4
to
1270fe2
Compare
calccrypto
reviewed
Sep 9, 2024
This comment was marked as outdated.
This comment was marked as outdated.
calccrypto
reviewed
Sep 9, 2024
calccrypto
reviewed
Sep 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
calccrypto
reviewed
Sep 9, 2024
calccrypto
reviewed
Sep 10, 2024
bwatkinson
requested changes
Sep 10, 2024
calccrypto
reviewed
Sep 17, 2024
calccrypto
reviewed
Sep 17, 2024
calccrypto
reviewed
Sep 17, 2024
calccrypto
reviewed
Sep 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
calccrypto
reviewed
Sep 17, 2024
cadegore
force-pushed
the
cadegore-xdd
branch
from
1677f41
to
5a93b3d
Compare
calccrypto
reviewed
Sep 23, 2024
calccrypto
reviewed
Sep 23, 2024
calccrypto
reviewed
Sep 23, 2024
bwatkinson
requested changes
Sep 23, 2024
cadegore
force-pushed
the
cadegore-xdd
branch
9 times, most recently
from
95ef0bc
to
7d0fd05
Compare
cadegore
force-pushed
the
cadegore-xdd
branch
3 times, most recently
from
c41e9ca
to
83d92bd
Compare
bwatkinson
requested changes
Oct 4, 2024
…tapattern wholefile (MigeljanImeri#38) This commit rewrites the logic for handling the -datapattern wholefile option to ensure that even when the blocksize (bs) is smaller than the request size (reqsize), the code runs without segmentation faults. The changes include calculating the offset within the data pattern buffer, allocating a buffer if not already allocated, and copying data in chunks from the data pattern to the buffer until the entire transfer size is copied. The offset is correctly calculated and reset after the first iteration. In addition, a test case also added to verify that the code correctly handles cases where the blocksize is smaller than the request size. The test compares the input file and output file to ensure they match and that the offset is correctly calculated with different numbers of queue depth (qd). Signed-off-by: Cade Gore <79346293+cadegore@users.noreply.github.com>
bwatkinson
approved these changes
Oct 5, 2024
calccrypto
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.