Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only support Linux #4

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Only support Linux #4

merged 1 commit into from
Aug 17, 2023

Conversation

calccrypto
Copy link
Collaborator

No description provided.

@bwatkinson
Copy link
Collaborator

Let's hold off on merging this one. There are a lot of places all over the code were we still need to remove #if for things like WIN32, DARWIN, AIX, FREEBSD. Also, I have no idea what IRIX is, but we would look at that too. We should clean out all non-Linux related code in one commit.

@calccrypto calccrypto force-pushed the linux-only branch 2 times, most recently from 615dec6 to 1ef1cb4 Compare June 22, 2023 23:30
@calccrypto calccrypto force-pushed the linux-only branch 4 times, most recently from 85dfc7b to 111af95 Compare June 26, 2023 17:15
@calccrypto calccrypto changed the title Only support Linux WIP: Only support Linux Jun 26, 2023
@calccrypto calccrypto changed the title WIP: Only support Linux Only support Linux Jun 26, 2023
@bwatkinson
Copy link
Collaborator

I will try and get time this week to help out with this. We really need to get this merged ASAP. The more code cleanup the better at this point.

@calccrypto calccrypto force-pushed the linux-only branch 2 times, most recently from ea2e7e5 to 0491256 Compare July 27, 2023 22:33
bwatkinson
bwatkinson requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@bwatkinson bwatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looked good to me and it builds so that is good lol. However, can you go into src/common/memory.c and remove the whole #ifdef notdef block in xdd_unlock_memory()? It seems to allude to being some old code for AIX. However, I honestly don't know what the purpose of it is in general as I don't see where notdef would be even set.

@calccrypto
Copy link
Collaborator Author

Removed

@calccrypto calccrypto merged commit 6b84daa into MigeljanImeri:xdd-2.0 Aug 17, 2023
2 checks passed
@calccrypto calccrypto deleted the linux-only branch August 17, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatkinson bwatkinson bwatkinson approved these changes

@MigeljanImeri MigeljanImeri MigeljanImeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calccrypto @bwatkinson @MigeljanImeri