Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wand aspect list display added, IAspectContainer display fixed #3524

Conversation

repo-alt
Copy link
Contributor

No description provided.

@asiekierka
Copy link
Contributor

> Task :sourceMainScala
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:8: object common is not a member of package thaumcraft
> Task :compileScala
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:20: not found: type ItemWandCasting
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:21: value getAllVis is not a member of net.minecraft.item.Item

Is there a way to implement this without depending on Thaumcraft internals? Even then, the build script would have to be adjusted...

@repo-alt
Copy link
Contributor Author

Well, I don't think we may expect another 1.7.10 Thaumcraft release, so it is probably safe to depend on the internal interface. (I have no idea why it is even internal)

@repo-alt
Copy link
Contributor Author

(Thaucraft API should probably be deleted from the repository if that PR is accepted, but that is up to you)

@asiekierka asiekierka added this to the OC 1.8.0 milestone Aug 29, 2022
@asiekierka asiekierka modified the milestones: OC 1.8.0, OC 1.9.0 May 30, 2023
@asiekierka asiekierka removed this from the OC 1.9.0 milestone Apr 7, 2024
@asiekierka asiekierka closed this in 3b60e93 Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants