Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dutch language code nl #50

Closed
wants to merge 2 commits into from
Closed

Use Dutch language code nl #50

wants to merge 2 commits into from

Conversation

cocoatomo
Copy link

This PR resolves issue #43 .

  • Replace du with nl contained in filenames and file contents
  • Leave lunr.du.js file as an alias of lunr.du.js

@MihaiValentin
Copy link
Owner

Thanks for this contribution and also for considering preventing breaking changes!

The lunr.<locale> and min/lunr.<locale> files are generated at build time, running npm run build.
Modifying them directly will just override them on next build.

I think the best way for now is to duplicate (create a new entry in build.js with nl, but identical to the one with du, and run the build script. You could also change the build script, so it could inject a message in the du file, like console.warning(message), in which case the message for du would be "The du language code was corrected to nl. Please use the nl, as in the next versions the du file will be removed".

Then, whenever I'll build a new breaking change version of the npm package, I'll delete the du file.

What do you think?

@MihaiValentin
Copy link
Owner

Added NL and deprecated DU (added a console.warn message). I'll close this PR.

@cocoatomo
Copy link
Author

Oh, thank you for your proposal and works 👍

@cocoatomo cocoatomo deleted the alias-du branch February 23, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants