NullReferenceException in XwaHookDialog ctor

[JeremyAnsel]

Reported by Darksaber at the XWAUP forum: YOGEME by JaggedFel

In XwaHookDialog.cs, there is this code:

_fileName = mission.MissionPath.Replace(".tie", ".ini");
...
StreamReader srMission = null;
if (File.Exists(_fileName)) srMission = new StreamReader(_fileName);
…
if (srMission != null)
{
    #region read
    …
    #endregion
}

srMission.Close();

When the ini file doesn't exist, srMission is null and a NRE is thrown at srMission.Close().

To fix the issue, place srMission.Close(); at the end of the if (srMission != null) block.

[MikeG621]

Bah. Fixing, will be up in a couple minutes. -- Michael Gaisser

…

On Mon, Sep 16, 2019 at 6:45 AM Jérémy Ansel ***@***.***> wrote: Reported by Darksaber at the XWAUP forum: YOGEME by JaggedFel <https://www.xwaupgrade.com/phpBB3/viewtopic.php?f=9&t=12313> In XwaHookDialog.cs <https://github.com/MikeG621/YOGEME/blob/master/XwaHookDialog.cs>, there is this code: _fileName = mission.MissionPath.Replace(".tie", ".ini"); ... StreamReader srMission = null; if (File.Exists(_fileName)) srMission = new StreamReader(_fileName); … if (srMission != null) { #region read … #endregion } srMission.Close(); When the ini file doesn't exist, srMission is null and a NRE is thrown at srMission.Close(). To fix the issue, place srMission.Close(); at the end of the if (srMission != null) block. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#27?email_source=notifications&email_token=AAHO5ESL5NORKTWHINPQQATQJ5WWPA5CNFSM4IXBD66KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLR2XTQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHO5EU4NEGPPE7CAEWUEX3QJ5WWPANCNFSM4IXBD66A> .

[MikeG621]

Fixed in 2d7678c and released