Crash on first run if games are not present or not completely installed

[chrisforbes]

I attempted to launch the 1.62 release build, but it would fail silently.

Built from source instead, and found that the initial settings write is throwing ArgumentNullException if BoP is not found (in Settings.cs:465).

This then leads to writing an incomplete settings file which will cause settings load to fail on subsequent attempts.

Similar issue (at Settings.cs:491) if XWA is not completely installed (in this case, I had the files present from the Steam version but initial setup (which adds all the required registry keys) was not done.

[MikeG621]

Hmm, that's odd since those paths default to an empty string, so it shouldn't throw null. I wonder if Steam is doing a partial install prior to first run, so it detects the "Steam App ######" key but the "InstallLocation" value isn't set yet, since that then could return null. Okay, easy enough to add a null check to that prior to write. -- Michael Gaisser

…

On Wed, Jan 1, 2020 at 7:15 PM Chris Forbes ***@***.***> wrote: I attempted to launch the 1.62 release build, but it would fail silently. Built from source instead, and found that the initial settings write is throwing ArgumentNullException if BoP is not found (in Settings.cs:465). This then leads to writing an incomplete settings file which will cause settings load to fail on subsequent attempts. Similar issue (at Settings.cs:491) if XWA is not completely installed (in this case, I had the files present from the Steam version but initial setup (which adds all the required registry keys) was not done. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=AAHO5ERGNEDU44UBYRS3HB3Q3U53PA5CNFSM4KB5UNU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDTF3WQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHO5ETLKTL4FGN7J3SNPZLQ3U53PANCNFSM4KB5UNUQ> .