-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring & Improvements #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I went through the code to improve the maintainability, and to make it easier for new contributors. The commits are broken down to explain each change, as follows:
extractor.py
to make it easier to find the file.Motivation and Context
I was planning for way too long to go over the code and start making it easier to new contributors to understand how it works.
Also during several tests the script was failing, which drives users away of it, so several fixes were needed.
It should be now on an okay-ish stage to start including improvements (eg. parallel scanning, IP rotations, etc)
How Has This Been Tested?
python torcrawl.py -w -u google.com -c -d 1 -p 1 -l -v -e
python torcrawl.py -w -u google.com -c -d 1 -p 1 -l -v
python torcrawl.py -w -u google.com -c -d 3 -l -v
Types of changes
Checklist: