Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-40: Allow using Mono editor to run GDScript tests #40

Closed
NaixGames opened this issue May 6, 2024 · 0 comments · Fixed by #41
Closed

GD-40: Allow using Mono editor to run GDScript tests #40

NaixGames opened this issue May 6, 2024 · 0 comments · Fixed by #41
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@NaixGames
Copy link

gdUnit allows quite easily to run quite easily tests in gdscript on the Mono editor. This includes running and interacting with scenes that might contain C# scripts without the need of using the C# runner. This has some advantages, as test in the editor are easier to run and set, which is useful for quickly setting up projects with collaborators. In that regard it is also convenient that the action can also support running gdscript tests while using the mono editor. However, right now the option godot-net controls both, the type of test getting run and the editor used to run it. So gdscript test wont be run if using godot-net set to true, and setting it to false will cause any test that contains a C# script to fail since the resource wont get properly compiled. This issue is not solvable with the actual flags for the action and it does not reflect the behaviour from the editor.

A solution to this would add a flag to choose to run (or not) the mono behaviour and another one to run C# tests. Lets call the first one godot-net (maintaining the same name as before) and the second one tests-net. The first flag is use on the action to decide which editor is used (which I think is lines 68, 88 and 136) and the second one to decide which tests are run (which I think are lines 168, 185, 194 and 210). However, I dont know if this would cause any other issue.

@NaixGames NaixGames added the enhancement New feature or request label May 6, 2024
@MikeSchulze MikeSchulze changed the title Allow using Mono editor to run gdscript GD-40: Allow using Mono editor to run gdscript May 11, 2024
@MikeSchulze MikeSchulze changed the title GD-40: Allow using Mono editor to run gdscript GD-40: Allow using Mono editor to run GDScript tests May 11, 2024
@MikeSchulze MikeSchulze added this to the v1.1.0 milestone May 11, 2024
MikeSchulze added a commit that referenced this issue May 11, 2024
# Why

see #40

# What
- Added new optional property ` godot-force-mono` to enforce running GDScript tests by using the Godot Mono executable
MikeSchulze added a commit that referenced this issue May 11, 2024
# Why

see #40

# What
- Added new optional property ` godot-force-mono` to enforce running GDScript tests by using the Godot Mono executable
MikeSchulze pushed a commit that referenced this issue May 11, 2024
# Why

see #40

# What
- Added new optional property ` godot-force-mono` to enforce running GDScript tests by using the Godot Mono executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants