Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-36: Fixes action fails with permission denied error when using an installed version #37

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

argusherd
Copy link
Contributor

@argusherd argusherd commented Apr 27, 2024

Why

the script exited at the 'Install gdUnit4 plugin - ${{ inputs.version }}' step when using an installed version without granting executable permission to the ./addons/gdUnit4/runtest.sh file
causing xvfb-run throws permission denied error
by adding a step to grant permission manually, this issue can be resolved
but in my humble opinion, it's a good idea to prevent users from encountering this type of gotcha

the workflow i'm using for reference:

name: "GDUnit4 CI action test"

on: workflow_dispatch

jobs:
  execute-gdunit:
    name: Run GDUnit4 tests
    runs-on: ubuntu-latest
    permissions:
      actions: write
      checks: write
      contents: write
      pull-requests: write
      statuses: write
    steps:
      - uses: actions/checkout@v4
      - name: "set permission"
        shell: 'bash'
        run: |
          chmod +x ./addons/gdUnit4/runtest.sh
      - uses: MikeSchulze/gdUnit4-action@v1.0.5
        with:
          godot-version: '4.2'
          godot-status: 'stable'
          version: 'installed'
          paths: 'res://tests'

What

Add chmod command to grant executable permission to the runtest.sh file.

#36

Add chmod command to grant executable permission to the runtest.sh file.
@MikeSchulze MikeSchulze changed the title Update action.yml GD-36: Update action.yml Apr 27, 2024
action.yml Show resolved Hide resolved
@MikeSchulze MikeSchulze changed the title GD-36: Update action.yml GD-36: Fixes action fails with permission denied error when using an installed version Apr 27, 2024
@MikeSchulze MikeSchulze merged commit 4055275 into MikeSchulze:master Apr 27, 2024
@argusherd argusherd deleted the GD-36 branch April 28, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-36: The action fails with Permission denied error when using an installed version
2 participants