One more improvement from review

Overlooked fixup
MikeSpreitzer · Feb 12, 2020 · fb1d177 · fb1d177
1 parent d5a572c
commit fb1d177
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/staging/kos/pkg/apis/network/types.go b/staging/kos/pkg/apis/network/types.go
@@ -84,8 +84,8 @@ func (writes WriteSet) SetWrite(section string, serverTime Timestamp) WriteSet {
 func (writes WriteSet) Diff(others WriteSet) WriteSet {
 	ans := make(WriteSet, 0, len(writes))
 	for _, wr := range writes {
-		owr, _ := others.GetWrite(wr.Section)
-		if owr == (ObjectWrite{}) {
+		_, found := others.GetWrite(wr.Section)
+		if !found {
 			ans = append(ans, wr)
 		}
 	}

diff --git a/staging/kos/pkg/apis/network/v1alpha1/types.go b/staging/kos/pkg/apis/network/v1alpha1/types.go
@@ -84,8 +84,8 @@ func (writes WriteSet) SetWrite(section string, serverTime Timestamp) WriteSet {
 func (writes WriteSet) Diff(others WriteSet) WriteSet {
 	ans := make(WriteSet, 0, len(writes))
 	for _, wr := range writes {
-		owr, _ := others.GetWrite(wr.Section)
-		if owr == (ObjectWrite{}) {
+		_, found := others.GetWrite(wr.Section)
+		if !found {
 			ans = append(ans, wr)
 		}
 	}

diff --git a/staging/kos/pkg/controllers/connectionagent/connection_agent.go b/staging/kos/pkg/controllers/connectionagent/connection_agent.go
@@ -1070,7 +1070,7 @@ func (ca *ConnectionAgent) updateLocalAttachmentStatus(att *netv1a1.NetworkAttac
 		updatedAtt.Status.PostCreateExecReport)
 
 	if att.Status.HostIP == "" {
-		ca.attachmentCreateToStatusHistogram.Observe(updatedAtt.Writes.GetServerWriteTime(netv1a1.NASectionAddr).Sub(att.Writes.GetServerWriteTime(netv1a1.NASectionSpec)).Seconds())
+		ca.attachmentCreateToStatusHistogram.Observe(updatedAtt.Writes.GetServerWriteTime(netv1a1.NASectionImpl).Sub(att.Writes.GetServerWriteTime(netv1a1.NASectionSpec)).Seconds())
 	}
 
 	return nil