Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: timeperiod at end #104

Merged
merged 5 commits into from
Sep 17, 2022
Merged

BUG: timeperiod at end #104

merged 5 commits into from
Sep 17, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Sep 17, 2022

Fix "at" for the end of periods.

@Miksus Miksus added the bug Something isn't working label Sep 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 95.50% // Head: 95.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (80e6e54) compared to base (9e3539b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          88       88           
  Lines        4604     4605    +1     
=======================================
+ Hits         4397     4398    +1     
  Misses        207      207           
Impacted Files Coverage Δ
rocketry/core/task.py 93.34% <ø> (-0.03%) ⬇️
rocketry/core/time/anchor.py 92.43% <100.00%> (+0.12%) ⬆️
rocketry/conditions/func.py 89.58% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus
Copy link
Owner Author

Miksus commented Sep 17, 2022

This also has minor fixes to log error handling. CI had again started crashing due to race conditions.

@Miksus Miksus merged commit 16de9ab into master Sep 17, 2022
@Miksus Miksus deleted the fix/timeperiod_at_end branch September 17, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants