Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add cron scheduler #73

Merged
merged 42 commits into from
Aug 12, 2022
Merged

ENH: Add cron scheduler #73

merged 42 commits into from
Aug 12, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Aug 11, 2022 •
edited
Loading

Add Cron style conditions.

This PR also has improvements on underlying time period mechanics most notably:

  • new condition TaskRunnable, similar to TaskExecutable
  • time periods are immutable dataclasses
  • fixed various bugs in time period All and Any (previously was not used)
  • fixed bug in StaticInterval if start/end was specified (previously was not used)
  • time periods are always left closed and right opened
  • always is now "singleton"
  • new method in time periods (create_range)
  • fixed if ints passed to time periods

Miksus added 30 commits August 6, 2022 22:25
@Miksus
fix: TimeOfYear and also int anchoring in time
2dc0aa1
@Miksus
add: always time period "singleton"
dd2d60e
@Miksus
upd: anchor time periods extends for full periods
84e34c4
@Miksus
fix: month/week names/abbrs always in English
a0ec20f 
Also now they are case insensitive.
@Miksus
fix: now interval is left by default
9d09dd5 
Also took off some incorrect closed.
@Miksus
fix: Now anchored periods are full by default
26af4ce 
This is if no start or end is given.
@Miksus
fix: And and Any time periods
b483ce7
@Miksus
fix: anchor_int with anchor periods
14f8137 
Now int goes by natural language
@Miksus
test: add more time construct tests
abfbdcd
@Miksus
upd: better reprs in time
2c56550
@Miksus
add: crontab period
63b13df
@Miksus
fix: full if end is scope_max in anchor
db37efa
@Miksus
add: time periods to frozen dataclasses
5a9dd5c
@Miksus
upd: time periods operates on microseconds
958bab5 
Python's datetime has resolution of one microsecond so microseconds
makes more sense. Also makes it possible to increment the datetimes
with minimum resolution (adding one nanosecond adds nothing).
@Miksus
fix: static interval
091527f 
Now also works with non permanent (start and end as None)
@Miksus
upd: now Interval is frozen dataclass as well
3cb7db7
@Miksus
fix: anchor end of the time period and time point
76f36ba
@Miksus
fix: time interval maximum includes end
626c4c5
@Miksus
test: fix some tests for new interpretation of end
0a2de2d 
Now the intervals are always right opened and left closed.
@Miksus
fix: time interval rollforward if it's empty
ff67cd2 
Note: this is not needed for rollback as left point is always included.
@Miksus
test: add is_full to tests
e91a32e
@Miksus
test: fix some tests related to timepoints and end
f65b2bb
@Miksus
add: option for right close
cda07cc
@Miksus
fix: immutable error in string setting in periods
db2bf75
@Miksus
test: add closed assertions
af9ec97
@Miksus
fix: time interval overlaps in All roll
7bbfff0
@Miksus
add: time period All and Any compression
2df17de
@Miksus
test: fix cron tests
f773605
@Miksus
add: create_range for anchored time periods
ebfd020 
This is useful for Cron skip.
@Miksus
upd: add start and end to time period create_range
17b78ce
Miksus added 4 commits August 11, 2022 08:13
@Miksus
upd: renamed crontab to cron and add step tests
8d03b01
@Miksus
add: TaskRunnable (similar to TaskExecutable)
6367d9e 
This condition is used similarly as TaskExecutable but instead of
relying on when the task finished, this relies on when the task started.
@Miksus
add: cron to cond API and cond syntax
9341e72
@Miksus
test: add sanity checks for continuous periods
1f7c5ad
@Miksus Miksus added enhancement New feature or request core Relates to the core functionalities (ie. base classes) built-in Relates to the built-in tasks, conditions etc. labels Aug 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #73 (c8a7028) into master (b837b8b) will increase coverage by 0.28%.
The diff coverage is 94.00%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   90.81%   91.10%   +0.28%     
==========================================
  Files          87       88       +1     
  Lines        4050     4339     +289     
==========================================
+ Hits         3678     3953     +275     
- Misses        372      386      +14
Impacted Files Coverage Δ
rocketry/conds/__init__.py 100.00% <ø> (ø)
rocketry/core/time/__init__.py 100.00% <ø> (ø)
rocketry/parse/time.py 100.00% <ø> (ø)
rocketry/core/time/base.py 84.14% <88.88%> (+3.22%) ⬆️
rocketry/core/time/anchor.py 87.71% <90.38%> (-1.26%) ⬇️
rocketry/pybox/time/interval.py 93.65% <92.00%> (-0.80%) ⬇️
rocketry/time/interval.py 96.29% <99.00%> (+5.82%) ⬆️
rocketry/conditions/api.py 96.87% <100.00%> (+0.18%) ⬆️
rocketry/conditions/task/task.py 91.97% <100.00%> (+0.58%) ⬆️
rocketry/core/time/utils.py 83.14% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Miksus Miksus merged commit 05861b7 into master Aug 12, 2022
@Miksus Miksus deleted the dev/cron-style branch August 12, 2022 20:30
@Miksus Miksus mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
built-in Relates to the built-in tasks, conditions etc. core Relates to the core functionalities (ie. base classes) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miksus @codecov-commenter