Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: TimeOfMinute subseconds #91

Merged
merged 13 commits into from
Sep 5, 2022
Merged

FIX: TimeOfMinute subseconds #91

merged 13 commits into from
Sep 5, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Sep 4, 2022

There was a bug in TimeOfMinute subseconds. Also the minutely condition did not work correctly for subseconds as well.

For example these did not work:

  • TimeOfMinute("15.2", "45.2")
  • TimeOfMinute("15.002", "45.002")

Additional changes:

  • Fix: other time periods end (only affects to the last microsecond)
  • Add: simpler starting mechanism
  • Add: better errors

@Miksus Miksus added bug Something isn't working built-in Relates to the built-in tasks, conditions etc. labels Sep 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #91 (1ad057e) into master (2413a22) will increase coverage by 0.13%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   91.44%   91.57%   +0.13%     
==========================================
  Files          89       89              
  Lines        4488     4500      +12     
==========================================
+ Hits         4104     4121      +17     
+ Misses        384      379       -5     
Impacted Files Coverage Δ
rocketry/time/interval.py 98.45% <92.85%> (+2.15%) ⬆️
rocketry/core/time/anchor.py 88.76% <100.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Miksus Miksus merged commit 3165590 into master Sep 5, 2022
@Miksus Miksus deleted the fix/minutely_subsecond branch September 5, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working built-in Relates to the built-in tasks, conditions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants