Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensional constraints (backend version 0.21) #389

Merged
merged 30 commits into from
Jul 28, 2023

Conversation

MilesCranmer
Copy link
Owner

@MilesCranmer MilesCranmer commented Jul 23, 2023

TODO:

  • Allow unicode printing
  • Integrate units.
    • We probably want to pass these as strings, otherwise we'd need to make a converter from some Python units package. Also astropy doesn't allow you to have different units in the same numpy array, so seems perhaps not optimal for this.
    • X_units and y_units parameters to .fit()?
  • Add print_precision parameter.
  • Add dimensional_constraints_penalty
  • Consider taking advantage of v_dim_out parameter.
  • Reach 100% diff coverage (see todo in tests file)
  • Test selection mask + units
  • Test pickling + units
  • Test re-fit + units
  • Add parameters to param groupings
  • Set y_variable_names

Fixes #283, #388

@MilesCranmer MilesCranmer changed the title Backend update 0.21.2 Dimensional constraints (backend version 0.21) Jul 23, 2023
@MilesCranmer MilesCranmer force-pushed the backend-update-0.21.2 branch from bfaf3e2 to 22eb380 Compare July 24, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Print with sigdigits
1 participant