Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equation splitting for unicode variables #223

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

MilesCranmer
Copy link
Owner

It seems like the code that splits an equation string into multiple lines for the progress bar was using linear indexing, whereas strings with unicode do not have indices 1, 2, 3...

e.g., the string "⋅⋅" has valid indices 1 and 4.

@MilesCranmer MilesCranmer merged commit e51ea7f into master Jun 19, 2023
@MilesCranmer MilesCranmer deleted the fix-unicode-printing branch June 19, 2023 06:05
@github-actions
Copy link
Contributor

Benchmark Results

master 9f78093... t[master]/t[9f78093...]
search/multithreading 0.0231 ± 0.0027 h 0.0232 ± 0.0013 h 0.997
search/serial 0.0229 ± 0.00038 h 0.0232 ± 0.0011 h 0.985
time_to_load 3.96 ± 0.1 s 4.07 ± 0.053 s 0.974
utils/best_of_sample 2.8 ± 1 μs 2.9 ± 1.1 μs 0.966
utils/check_constraints_x10 21.2 ± 5.3 μs 19.4 ± 5.2 μs 1.09
utils/compute_complexity_x10/Float64 4.1 ± 0.4 μs 3.8 ± 0.3 μs 1.08
utils/compute_complexity_x10/Int64 3.7 ± 0.3 μs 3.7 ± 0.3 μs 1
utils/compute_complexity_x10/nothing 2.6 ± 0.3 μs 2.7 ± 0.3 μs 0.963
utils/optimize_constants_x10 0.0719 ± 0.015 s 0.0731 ± 0.015 s 0.984

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant