Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for MLJModelInterface to 1, (keep existing compat) #322

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 4, 2024

This pull request changes the compat entry for the MLJModelInterface package from ~1.5, ~1.6, ~1.7, ~1.8, ~1.9 to ~1.5, ~1.6, ~1.7, ~1.8, ~1.9, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-06-04-00-09-45-241-03026204066 branch from 84ecccc to 530e532 Compare June 4, 2024 00:09
Copy link
Contributor Author

github-actions bot commented Jun 4, 2024

Benchmark Results

master b1430e6... master/b1430e6fe8e00c...
search/multithreading 19.8 ± 0.5 s 19.5 ± 0.32 s 1.01
search/serial 34.4 ± 0.048 s 34.5 ± 0.13 s 0.996
utils/best_of_sample 0.931 ± 0.36 μs 0.972 ± 0.39 μs 0.958
utils/check_constraints_x10 12.2 ± 3.4 μs 12.2 ± 3.2 μs 0.997
utils/compute_complexity_x10/Float64 2.22 ± 0.12 μs 2.21 ± 0.12 μs 1
utils/compute_complexity_x10/Int64 2.2 ± 0.12 μs 2.2 ± 0.12 μs 1
utils/compute_complexity_x10/nothing 1.49 ± 0.11 μs 1.57 ± 0.1 μs 0.949
utils/optimize_constants_x10 0.0318 ± 0.0067 s 0.0317 ± 0.0065 s 1
time_to_load 0.925 ± 0.014 s 0.927 ± 0.0082 s 0.998

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer enabled auto-merge June 16, 2024 00:51
@MilesCranmer MilesCranmer disabled auto-merge June 16, 2024 00:54
@MilesCranmer MilesCranmer merged commit f96b942 into master Jun 16, 2024
14 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-06-04-00-09-45-241-03026204066 branch June 16, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant