Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of timestamps and headers, with explicit errors for old rip format #73

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

MilesCranmer
Copy link
Owner

@MilesCranmer MilesCranmer commented Dec 22, 2024

This also:

  1. Refactors a lot of the Record and RecordItem structs to eliminate code reuse.
  2. Removes the extra file creation step within write_log to be similar in function to the other steps.

This fixes #67 by giving a more helpful error message for inability to parse the date format due to usage of old rip.

@chrisgeo do you think this would be worth it? It would also be helpful if you could test it on your "real-world" corrupted .record! I try to simulate a couple but want to make sure it works for yours as well.

@MilesCranmer MilesCranmer force-pushed the compat-helpful-error branch 2 times, most recently from 0c4cac8 to 5c318cf Compare December 22, 2024 23:23
@chrisgeo
Copy link

Your test case looks to cover it all. I’ll see if I can get my rust env setup to compile.

@MilesCranmer MilesCranmer merged commit 3dd872b into master Dec 24, 2024
19 checks passed
@MilesCranmer MilesCranmer deleted the compat-helpful-error branch December 24, 2024 19:15
@MilesCranmer MilesCranmer restored the compat-helpful-error branch December 24, 2024 19:19
@MilesCranmer MilesCranmer deleted the compat-helpful-error branch December 24, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse time from RFC3339 format
2 participants