Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be scrollable if chart does not fit in the view #91

Closed
Floppe opened this issue Feb 1, 2023 · 4 comments · Fixed by #102
Closed

Should be scrollable if chart does not fit in the view #91

Floppe opened this issue Feb 1, 2023 · 4 comments · Fixed by #102
Assignees
Labels
bug Something isn't working

Comments

@Floppe
Copy link

Floppe commented Feb 1, 2023

A huge thank you for this amazing component. I really love it.

Checklist:

  • [* ] I updated to the latest version available
  • [* ] I cleared the cache of my browser

Release with the issue:
v1.9.3

Last working release (if known):

Browser and Operating System:
Windows 10 and Chrome 109 with large monitors -> OK
Android 11 and Chrome with small screen and portrait orientation -> not so good

Description of problem:
Some days ago I added another section so I get energy consumption per room in my house also. That's when it started to become more difficult to see sensors in my mobile.

When sankey charts have 4 or more sections, then the width will grow beyond my mobile phones capabilities in portrait orientation. This makes all other components in that view wider and difficult to look at.

Javascript errors shown in the web inspector (if applicable):

Additional information:
Perhaps not a bug per see, but I believe all components should handle these basic things so filing it as a bug. Maybe related to #86. I have fiddled with the wide option without success.

So better would be that the entire component becomes scrollable when it does not fit in the view.

Also, I'm using the view type grid everywhere.

@Floppe Floppe added the bug Something isn't working label Feb 1, 2023
@MindFreeze MindFreeze self-assigned this Feb 1, 2023
@MindFreeze
Copy link
Owner

I am aware of this and am thinking about it but am not sure if scrolling is the solution yet. I've also been thinking about a vertical layout for mobile but that would be a huge change.
For now I just turn my phone horizontally :/

@Floppe
Copy link
Author

Floppe commented Apr 5, 2023

I don't really get how I should make it work so the chart becomes scrollable with this on smaller screens?

@MindFreeze
Copy link
Owner

You can now set minimum width per section. If the screen width is less than the sum of min width of all sections. The card will extend beyond the screen and be scrollable

@Floppe
Copy link
Author

Floppe commented Apr 5, 2023

Ah, got it. Thanks, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants