Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception for sankey chart #35

Closed
Floppe opened this issue Jan 24, 2023 · 10 comments
Closed

Exception for sankey chart #35

Floppe opened this issue Jan 24, 2023 · 10 comments
Labels
🆕 new swipe exception A new swipe exception to be added to defaults

Comments

@Floppe
Copy link

Floppe commented Jan 24, 2023

Would it be possible to allow scrolling a sankey chart if it does not fit on screen, without swiping to next?

https://github.com/MindFreeze/ha-sankey-chart

@zanna-37 zanna-37 added the 🆕 new swipe exception A new swipe exception to be added to defaults label Jan 25, 2023
@zanna-37
Copy link
Owner

Yes, I'll probably add it this weekend.

@zanna-37
Copy link
Owner

@Floppe, just a question, how do you make the chart scrollable? It appears to be of a fixed size by default.

@zanna-37 zanna-37 added the 🚧⚙️ work in progress... Issues I'm working on label Jan 31, 2023
@Floppe
Copy link
Author

Floppe commented Jan 31, 2023

It resizes itself pretty good, but 4+ sections does not fit on a mobile screen for me. I have only set height in the sankey code template.

Desktop example:
image

Mobile example:
image

@zanna-37
Copy link
Owner

Ok, but, is there a scrollbar or something that can scroll? Otherwise there is no point in adding it in the exceptions.

@Floppe
Copy link
Author

Floppe commented Feb 1, 2023

Ah, I didn't think of that. No, it's the entire view that scrolls. Perhaps I need to start an issue with sankey component first that it should be scrollable if it does not fit in the view.

@zanna-37
Copy link
Owner

zanna-37 commented Feb 1, 2023

Yeah, I think I'll be better. From my point of view, the fact that it doesn't fit the screen when on mobile it's a bug from their side. In the screenshot you provided, the card goes beyond the view limit, and that shouldn't happen in my opinion.

@zanna-37 zanna-37 added 🔍 more info needed Further information is requested and removed 🚧⚙️ work in progress... Issues I'm working on labels Feb 8, 2023
@zanna-37
Copy link
Owner

zanna-37 commented Feb 8, 2023

The issue on Sankey repo is tracked here MindFreeze/ha-sankey-chart#91.

@zanna-37 zanna-37 removed the 🔍 more info needed Further information is requested label Mar 15, 2023
@zanna-37
Copy link
Owner

zanna-37 commented Apr 4, 2023

Everything should be fixed on v1.11.1. Let me know. Thanks =)

@Floppe
Copy link
Author

Floppe commented Apr 5, 2023

Yes, v1.11.0 do handle so the view is scrollable when I set a fixed size for all sections.

@zanna-37
Copy link
Owner

zanna-37 commented Apr 5, 2023

Out of curiosity, can you provide the code to set a fixed size for all sections?

@zanna-37 zanna-37 closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 new swipe exception A new swipe exception to be added to defaults
Projects
None yet
Development

No branches or pull requests

2 participants