Auto layout DSL #210
Auto layout DSL #210
Conversation
ivopintodasilva
requested review from
renatorodrigues,
beloso,
p4checo,
portellaa,
diogoeiras,
tiagoalexbastos,
andremartingo,
filipe-lemos,
ricardomsm and
Feelleh
|
ReusableView unit tests are breaking but #208 is already open to fix them 👼 |
ivopintodasilva
force-pushed
the
feature/add-auto-layout-dsl
branch
from
414b776
to
a737f15
Compare
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 94.95% 95.36% +0.41%
==========================================
Files 94 101 +7
Lines 3408 4034 +626
==========================================
+ Hits 3236 3847 +611
- Misses 172 187 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Left a couple of 💅 comments now that we can take advantage of Swift 5.1's implicit return's, which will make the code look tidier and more compact 😌
The test coverage is a bit lacking though, and if we merge this as is we will drop the project's overall coverage by 10.83% 😢, so I think we should add some more tests to address this. I'll gladly help if you want.
- Internally using `NSLayoutConstraints` - Constrainable proxies created for a more "suggary" and readable syntax - Added Array extensions to handle bulk constraint application - Added unit tests
ivopintodasilva
force-pushed
the
feature/add-auto-layout-dsl
branch
from
a737f15
to
a9ad12a
Compare
|
Applied code review suggestions and rebased branch. Currently improving test coverage 📈 |
|
Code coverage replenished 😌 |
Checklist
masterMotivation and Context
The
NSLayoutAnchorAPI is very verbose and resulted on big blocks of Auto Layout code that increased the size of the view files and was not very easy to read.As an alternative, Cartography provides a simple and readable DSL to handle Auto Layout code but we've found that the operator overload used on that library was causing our compile times to increase.
Description
All credit goes to @renatorodrigues for the implementation 🙏
The implementation is heavily inspired on Cartography and TinyConstraints.
Without using custom operators, we can still have a more accessible API for our Auto Layout code and avoid the increased build times caused by operator overloads.