-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configurable timeouts #320
Conversation
…efault of Node's http/https libs as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I think it can be simplified a bit if the RaygunOptions get unified to a single config property for timeout.
Also, we should document this option in the README.md
before merging.
@miquelbeltran This is complete now and all PR comments resolved. Feel free to re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
feat: #319 - Missing timeouts
Description 📝
send
call? #311 (to be seen)timeout
as an option and an explicit default HTTP timeout of 5000mshttp
andhttps
modules in Node to not stop a request even when it runs into a timeoutType of change
Updates
👉 Changed TS types
👉 Changes to transport layer
👉 Introduced new option
👉 Added tests to the mocking test bed
👉 TDB: Update documentation
Test plan 🧪
The easiest way to test under RL scenarios is with the express sample app. Set an API key and then configure
raygun.client.js
with options such as for example:Author to check 👓
Reviewer to check ✔️