Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds internal Sidekiq class to default ignore list #180

Merged
merged 1 commit into from
May 9, 2024

Conversation

nikz
Copy link
Contributor

@nikz nikz commented May 9, 2024

Sidekiq::JobRetry::Skip is used for retry control and isn't really a resolvable error to track

As per recommendation from the Sidekiq maintainer

`Sidekiq::JobRetry::Skip` is used for retry control and isn't really a
resolvable error to track

As per [recommendation from the Sidekiq
maintainer](rails/rails#43625 (comment))
@nikz nikz requested a review from sumitramanga May 9, 2024 01:34
@nikz nikz self-assigned this May 9, 2024
Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikz nikz merged commit ce2dd08 into MindscapeHQ:master May 9, 2024
12 checks passed
@nikz nikz deleted the ignore-sidekiq-exception branch May 9, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants