Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes backward incompatible Sidekiq change #184

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

nikz
Copy link
Contributor

@nikz nikz commented May 29, 2024

We are expecting a config argument to the Sidekiq exception handler, but pre- version 7.1.5 that is not passed.

So we'll make the argument optional as it is currently unnused anyway

Fixes #183

We are expecting a `config` argument to the Sidekiq exception handler,
but pre- version 7.1.5 that is not passed.

So we'll make the argument optional as it is currently unnused anyway

Fixes MindscapeHQ#183
@nikz nikz requested a review from sumitramanga May 29, 2024 04:05
@nikz nikz self-assigned this May 29, 2024
Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thank you for the quick PR 🌟

@nikz nikz merged commit 0da2d2f into MindscapeHQ:master Jun 1, 2024
12 checks passed
@nikz nikz deleted the fix-sidekiq-error-handler-api-change branch June 1, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidekiq error handler only compatible with Sidekiq >= 7.1.5
2 participants