Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for a retry count and raising #187

Merged

Conversation

nikz
Copy link
Contributor

@nikz nikz commented Sep 20, 2024

Adds two new configuration settings:

  • Configure how many times raygun4ruby should retry sending the error to the Raygun servers using error_report_max_attempts (defaults to 1)
  • Configure whether or not raygun4ruby should re-raise an exception if the send fails using raise_on_failed_error_report (defaults to false)

Adds two new configuration settings:

  * Configure how many times raygun4ruby should retry sending the error
    to the Raygun servers using `error_report_max_attempts` (defaults
    to 1)
  * Configure whether or not raygun4ruby should re-raise an exception if
    the send fails using `raise_on_failed_error_report` (defaults to
    false)
@nikz nikz self-assigned this Sep 20, 2024
Copy link

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is there maybe a point in documenting this new configuration somewhere?

@TheRealAgentK
Copy link

LGTM - is there maybe a point in documenting this new configuration somewhere?

Ah, just saw that in Readme you link to the actual configuration ruby file. Okis then :)

@nikz nikz merged commit bbbad39 into MindscapeHQ:master Oct 16, 2024
12 checks passed
@nikz nikz deleted the support-retry-count-and-failsafe-raise branch October 16, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants