Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: update mcfunction linguist language to use syntax-mcfunction #17

Open
TheAfroOfDoom opened this issue Jun 28, 2024 · 2 comments

Comments

@TheAfroOfDoom
Copy link

TheAfroOfDoom commented Jun 28, 2024

Summary

A few years ago, @Arcensoth submitted and merged a PR that added language-mcfunction to linguist. This enabled syntax highlighting for .mcfunction files in GitHub! (among other things probably, idk)

github-linguist/linguist#4425

We should update linguist to instead use this repo (syntax-mcfunction) so we get more up-to-date highlighting when we push .mcfunctions.

I don't know the full extent of this, but since Arcensoth has already laid the groundwork I hope it should be relatively straightforward (probably just updating the submodule to point to syntax-mcfunction instead of language-mcfunction).

Basic Example

Some notable current syntax highlighting mishaps include the following cases, as well as whatever other mcfunction language features that have changed since language-mcfunction's last update:

  • macros show up as a full red line
  • line continuation doesn't work

Is this specific to a text editor?

Other (please specify above)

Other Info

No response

@RitikShah
Copy link
Collaborator

Haha, that's the plan. Tbh, I should have committed for this ages ago but I wanted to get syntax-mcfunction 1:1 to language-mcfunction (it really isn't but it's as close considering the differing architecture).

I want to release a v1.0 so I'm collecting last minute feedback and then I'll make a PR for linguist. This issue will serve as my linguist TODO!

@RitikShah
Copy link
Collaborator

Created github-linguist/linguist#6916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants