Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mcfunction grammar #6916

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

RitikShah
Copy link
Contributor

@RitikShah RitikShah commented Jun 28, 2024

I'm replacing the grammar for mcfunction (introduced in #4425 by @Arcensoth) from language-mcfunction to syntax-mcfunction.

Description

syntax-mcfunction is a new grammar written from scratch to support the newer features of Minecraft commands in newer versions of the game. This grammar was actually a prototype of a rework that Arcensoth and I planned on working together on. Unfortuntely, Arcensoth unexpectedly passed away. This grammar is now in the MinecraftCommands org so that it's easier to get more contributors from the community (atm, I'm the sole maintainer).

The README contains a lot of detail for how this grammar differentiates itself from the original but the key differences are that it supports multi-line command and it lacks a lot of error highlighting to support future versions and custom commands (via mods or custom pre-processors). This is much more of a permissive highlighter which supports more of the community projects (such as bolt which can specify .bolt files being highlighted by the .mcfunction language via a .gitattributes file).

Checklist:

Questions

It seems like I have 1 warning related to the say repo, I'm not entirely sure how to parse this so I might need some help to figure this out. Please let me know if I need to follow any other instructions from the contributing guide.

@lildude lildude changed the title replace language-mcfunction -> syntax-mcfunction Replace mcfunction grammar Jul 9, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Aug 29, 2024
Merged via the queue into github-linguist:master with commit e96062f Aug 29, 2024
5 checks passed
@RitikShah RitikShah deleted the mcfunction branch August 29, 2024 18:26
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants