fix: don't install external file if not required

It's simply too hard to reliably disable external files, as they can be extracted into directories.
MinecraftMachina · Nov 22, 2020 · 612a962 · 612a962
1 parent 7bf4b31
commit 612a962
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/curseforge/installer.go b/curseforge/installer.go
@@ -252,7 +252,7 @@ func (i *ModpackInstaller) processMods(manifest *CornManifest, destPath string)
 			return err
 		}
 		request := resp.Request
-		if file, ok := request.Tag.(ExternalFile); ok && file.Extract.Enable {
+		if file, ok := request.Tag.(ExternalFile); ok && file.Extract.Enable && file.Required {
 			log.Printf("Extracting external file '%s'...", file.Name)
 			if err := i.extractExternalFile(file, request.Filename); err != nil {
 				return err