Fix FeatureFlagGenerator.java to generate in the correct format #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theEvilReaper
pushed a commit
to OneLiteFeatherNET/MinestomDataGenerator
that referenced
this pull request
Jun 25, 2024
…stom#28) * Add generation of feature flag namespaces. * Rewrite FeatureFlagGenerator.java to use a JsonObject instead of a JsonArray. --------- Co-authored-by: iam <iam4722202468@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I naively thought I could generate it as a JsonArray instead of a JsonObject, but that backfired so I rewrote it to do it how I should've in the first place. This needs to be merged and used in Minestom before this PR can be merged.