Make use of AuthorizeRequest to ensure a 401 status code for single profiler result #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, but you are missing a closing parentheses on the if line (please squash to one commit) |
…rofiler result If a non-authorized user visits a MiniProfiler results url (e.g. `http://app.com/mini-profiler-resources/results?id=<guid>`), they do *not* get a 401 status code. Having a 401 status code is what the documentation for `MiniProfiler.Settings.Results_Authorize` says it should return.
|
@yellis Fixed and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-authorized user visits a MiniProfiler results url (e.g.
http://app.com/mini-profiler-resources/results?id=<guid>), they do not get a 401 status code. Having a 401 status code is what the documentation forMiniProfiler.Settings.Results_Authorizesays it should return.