FEATURE: Use speedscope to display flamegraphs and switch from the flamegraph gem to stackprof #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amegraph gem to stackprof Mini Profiler now ships with an embedded copy of speedscope which provides a very nice experience for viewing flamegraphs. Flamegraph has been replaced with the stackprof gem. It's an optional dependency, so if you use the flamegraphs feature, you'll need to add the `stackprof` gem to your `Gemfile` and require it. If you don't use the feature, you don't need to add anything and Mini Profiler will work just fine.
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 87.89% 87.69% -0.21%
==========================================
Files 18 18
Lines 1239 1243 +4
==========================================
+ Hits 1089 1090 +1
- Misses 150 153 +3
Continue to review full report at Codecov.
|
|
Looks great to me 🎊 Let's add a rake task to update us to latest speedscope |
|
Hi! I'm the author of speedscope and just wanted to say that this is awesome! I made an opinionated fork of rack-mini-profiler in the past to do this (https://github.com/jlfwong/rack-mini-profiler), but so happy this is in |
|
Hi Jamie, huge fan! Thanks so much for building speedscope
…On Fri, 15 Jan 2021 at 8:40 pm, Jamie Wong ***@***.***> wrote:
Hi! I'm the author of speedscope and just wanted to say that this is
awesome! I made an opinionated fork of rack-mini-profiler in the past to do
this (https://github.com/jlfwong/rack-mini-profiler), but so happy this
is in rack-mini-profiler core now!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#475 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABIXPXNV7HEUOSHK24IZLS2AEPNANCNFSM4VI2PY5Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mini Profiler now ships with an embedded copy of speedscope which
provides a very nice experience for viewing flamegraphs.
Flamegraph has been replaced with the stackprof gem. It's an optional
dependency, so if you use the flamegraphs feature, you'll need to add
the
stackprofgem to yourGemfileand require it. If you don't usethe feature, you don't need to add anything and Mini Profiler will work
just fine.