-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voyager Backend #41
Voyager Backend #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sky-2002 , thanks a lot for making this PR! I think it's almost good to go, just a couple of small comments.
One other comment: could you also add Voyager to the tested backends? It should be as simple as adding Voyager here: https://github.com/MinishLab/vicinity/blob/main/tests/conftest.py#L32, and running make test to see if everything works as expected.
A couple of other comments:
Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this 🙏 ! I second @Pringled's comments about the tests, docs and requirements.
Codecov ReportAttention: Patch coverage is
|
@sky-2002 voyager isn't installed in CI yet, which is why these tests all fail. Could you add it to the list of extra in the Makefile? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks for this addition!
This PR adds voyager backend
Related issue: #40