Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: imports #43

Merged
merged 3 commits into from
Dec 6, 2024
Merged

clean: imports #43

merged 3 commits into from
Dec 6, 2024

Conversation

stephantul
Copy link
Contributor

Weird: we had several unused imports, but those weren't flagged by any linters we have configured.

Turns out we were missing the 'F' rule. I added it, and removed the unused imports.

@stephantul stephantul requested a review from Pringled December 5, 2024 06:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
vicinity/backends/basic.py 78.03% <100.00%> (-12.30%) ⬇️
vicinity/backends/faiss.py 94.87% <ø> (ø)
vicinity/backends/hnsw.py 95.31% <100.00%> (-2.97%) ⬇️
vicinity/datatypes.py 100.00% <ø> (ø)
vicinity/vicinity.py 99.13% <ø> (+1.45%) ⬆️

Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@stephantul stephantul merged commit 8c7e13b into main Dec 6, 2024
5 checks passed
@Pringled Pringled deleted the clean-up-imports branch December 11, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants