Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Minishlink/web-push version 5 #12

Closed
arjenm opened this issue Mar 27, 2019 · 4 comments
Closed

Support Minishlink/web-push version 5 #12

arjenm opened this issue Mar 27, 2019 · 4 comments

Comments

@arjenm
Copy link

arjenm commented Mar 27, 2019

This bundle is limited to version 4 of minishlink/web-push, but version 5 is here for some time now. Please support it in a new major version of the.

And perhaps just skip version 4 in that bundle to synchronize the major version of the bundle with the main library :)

It appears there is one deprecation which pops up with 4.2

$treeBuilder = new TreeBuilder();

        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('minishlink_web_push');
// Should become
        $treeBuilder = new TreeBuilder('minishlink_web_push');
        $rootNode = $treeBuilder->getRootNode();
@juliusstoerrle
Copy link
Contributor

the deprecation warning would fixed by the update to symfony 5 in #14

@Minishlink
Copy link
Owner

Fixed in v4.0.0, thanks guys!

@juliusstoerrle
Copy link
Contributor

I did not update the minishlink/web-push version to V5 only symfony. So this is still open. I will create a pull request for this. There are two options either allow ^5.0 or ^4.0.0|^5.0, not sure what you prefer?

@arjenm
Copy link
Author

arjenm commented Dec 11, 2019

The bundle should work with the latest version of what it bundles. But you're right that can be done with still supporting v4.

However, there were some BC-changes with minishlink/web-push v5, so perhaps its more correct to create a v5 of this bundle that only supports v5 of minishlink/web-push. Than again, that may be confusing since v5 of Symfony was also just released :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants