Make bundle compatible with Symfony 5 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when you have tested it, and I'll merge, thanks! |
juliusstoerrle
force-pushed
the
patch-1
branch
from
6b8cb39 to
8b5c872
Compare
|
As the TreeBuilder changed I had to update the code aswell. The constructor parameter of the TreeBuilder is only available since 4.2. I therefore also raised the minimum required symfony version to 4.2. I think it is alright, but people still using symfony 3.4 will need to use a previous version of this library. |
|
I tested this branch with Symfony version 5 and it worked without problems so far. From my side it would be ready for a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update composer.json to include Symfony V5.
Fixes #13
I have NOT tested the changes yet.